Re: [RFC][PATCH] rmdir(),rename(): do shrink_dcache_parent() only on success

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, May 27, 2018 at 3:20 PM Al Viro <viro@xxxxxxxxxxxxxxxxxx> wrote:

> We should've done that call right *after* successful ->rmdir().  That
> reduces contention caused by tree-walking in shrink_dcache_parent()
> and, especially, contention caused by evictions in two nested subtrees
> going on in parallel.  The same goes for directory-overwriting rename() -
> the story there had been parallel to that of rmdir().

Looks eminently sane to me.

               Linus



[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]

  Powered by Linux