On Tue, 22 May 2018 08:28:06 +0200 Christoph Hellwig <hch@xxxxxx> wrote: > On Mon, May 21, 2018 at 11:04:10AM +0200, Jan Kara wrote: > > We definitely do have customers using "execute in place" on s390x from > > dcssblk. I've got about two bug reports for it when customers were updating > > from old kernels using original XIP to kernels using DAX. So we need to > > keep that working. > > That is all good an fine, but I think time has come where s390 needs > to migrate to provide the pmem API so that we can get rid of these > special cases. Especially given that the old XIP/legacy DAX has all > kinds of known bugs at this point in time. I haven't yet looked at this patch series, but I can feel that this FS_DAX_LIMITED workaround is beginning to cause some headaches, apart from being quite ugly of course. Just to make sure I still understand the basic problem, which I thought was missing struct pages for the dcssblk memory, what exactly do you mean with "provide the pmem API", is there more to do? I do have a prototype patch lying around that adds struct pages, but didn't yet have time to fully test/complete it. Of course we initially introduced XIP as a mechanism to reduce memory consumption, and that is probably the use case for the remaining customer(s). Adding struct pages would somehow reduce that benefit, but as long as we can still "execute in place", I guess it will be OK. Regards, Gerald
