On Wed 23-05-18 13:58:24, Jan Kara wrote: > On Fri 18-05-18 01:06:25, Al Viro wrote: > > open file, unlink it, then use ioctl(2) to make it immutable or > > append only. Now close it and watch the blocks *not* freed... > > > > Immutable/append-only checks belong in ->setattr(). > > Note: the bug is old and backport to anything prior to 737f2e93b972 > > ("ext2: convert to use the new truncate convention") will need > > these checks lifted into ext2_setattr(). > > > > Cc: stable@xxxxxxxxxx > > Signed-off-by: Al Viro <viro@xxxxxxxxxxxxxxxxxx> > > Sorry, I've been busy with other stuff after LSF/MM and then forgot about > this. Thanks for the patch! I've added the patch to my tree. Bah, and now I see (thanks Amir for the notice) you've already pushed it to Linus. Sorry for the noise. Honza -- Jan Kara <jack@xxxxxxxx> SUSE Labs, CR