On 5/22/18 11:30 AM, Jens Axboe wrote: > On 5/22/18 12:30 PM, Al Viro wrote: >> On Tue, May 22, 2018 at 11:55:04AM -0600, Jens Axboe wrote: >>> On 5/22/18 11:52 AM, adam.manzanares@xxxxxxx wrote: >>>> From: Adam Manzanares <adam.manzanares@xxxxxxx> >>>> >>>> This is the per-I/O equivalent of the ioprio_set system call. >>>> See the following link for performance implications on a SATA HDD: >>>> https://lkml.org/lkml/2016/12/6/495 >>>> >>>> First patch factors ioprio_check_cap function out of ioprio_set system call to >>>> also be used by the aio ioprio interface. >>>> >>>> Second patch converts kiocb ki_hint field to a u16 to avoid kiocb bloat. >>>> >>>> Third patch passes ioprio hint from aio iocb to kiocb and initializes kiocb >>>> ioprio value appropriately when it is not explicitly set. >>>> >>>> Fourth patch enables the feature for blkdev. >>>> >>>> Fifth patch enables the feature for iomap direct IO >>> >>> LGTM, you can add: >>> >>> Reviewed-by: Jens Axboe <axboe@xxxxxxxxx> >>> >>> Al, are you picking this series up, or should I? >> >> Probably better if I do, once I finish reviewing Christoph's patchset - >> we already have a bunch of stuff around fs/aio.c in this cycle... > > Alright, sounds good, thanks Al. > I was working on the man page update for this feature and noticed I could be bit more informative on error if I return the error value returned by ioprio_check_cap in fs/aio.c. Should I resend the whole series?
