On Tue 22-05-18 10:37:53, Jan Kara wrote: > On Mon 21-05-18 14:36:03, Gabriel Krisman Bertazi wrote: > > Generated with the following coccinele script: > > > > <smpl> > > > > @@ > > expression A, B, C, D; > > @@ > > ( > > - A->uni2char(B, C, D) > > + nls_uni2char(A, B, C, D) > > | > > - A->char2uni(B, C, D) > > + nls_char2uni(A, B, C, D) > > ) > > > > </smpl> > > > > Signed-off-by: Gabriel Krisman Bertazi <krisman@xxxxxxxxxxxxxxx> > > fs/udf/unicode.c also uses char2uni and uni2char but evades your SMPL > patch. So you'll need to fix that up manually. Also note that I have some > changes to that area queued in my tree. Ah, OK, now I see that you've handled that in patch 3. Sorry for the noise. > > Honza > > -- > Jan Kara <jack@xxxxxxxx> > SUSE Labs, CR -- Jan Kara <jack@xxxxxxxx> SUSE Labs, CR