Re: [PATCH 05/34] fs: use ->is_partially_uptodate in page_cache_seek_hole_data

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> > diff --git a/fs/iomap.c b/fs/iomap.c
> > index bef5e91d40bf..0fecd5789d7b 100644
> > --- a/fs/iomap.c
> > +++ b/fs/iomap.c
> > @@ -594,31 +594,54 @@ EXPORT_SYMBOL_GPL(iomap_fiemap);
> >   *
> >   * Returns the offset within the file on success, and -ENOENT otherwise.
> 
> This comment is now wrong, since we return the offset via *lastoff and I
> think the return value is whether or not we found what we were looking
> for...?

Yes.  I'll just drop the comment as it doesn't add much value to start
with.

> > +	if (bsize == PAGE_SIZE || !ops->is_partially_uptodate) {
> > +		if (PageUptodate(page) == seek_data)
> > +			return true;
> > +		return false;
> 
> return PageUptodate(page) == seek_data; ?

Sure, I'll uptodate the patch.



[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]

  Powered by Linux