Re: [RFC][PATCH] affs_lookup(): close a race with affs_remove_link()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, May 13, 2018 at 05:00:40PM +0100, Al Viro wrote:
> [#fixes unless somebody yells; -stable fodder and yes, it _is_ that old -
> all way back to 2001]
> 
> we unlock the directory hash too early - if we are looking at secondary
> link and primary (in another directory) gets removed just as we unlock,
> we could have the old primary moved in place of the secondary, leaving
> us to look into freed entry (and leaving our dentry with ->d_fsdata
> pointing to a freed entry).
> 
> Cc: stable@xxxxxxxxxxxxxxx # 2.4.4+
> Signed-off-by: Al Viro <viro@xxxxxxxxxxxxxxxxxx>

Sorry for the delay. As far as my limited knowledge of the AFFS code
goes, this change looks ok. You can add my

Acked-by: David Sterba <dsterba@xxxxxxxx>

and please take it through the vfs tree. Thanks.



[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]

  Powered by Linux