Hi Amir, I'm just going through your patches and pushing them to my tree and I have one question here: On Fri 20-04-18 16`:10:54, Amir Goldstein wrote: > + fsnotify_foreach_obj_type(type) { > + if (!fsnotify_iter_should_report_type(iter_info, type)) > + continue; > + mark = iter_info->marks[type]; > + if (!mark) > + continue; How could possibly mark be NULL here when fsnotify_iter_should_report_type() returned true? I suppose it's a leftover from some older version of the series but wanted to check whether I'm not missing something. Honza -- Jan Kara <jack@xxxxxxxx> SUSE Labs, CR