On Thu, May 17, 2018 at 10:28 PM, Ronnie Sahlberg <lsahlber@xxxxxxxxxx> wrote: > Very nice. > > Acked-by: Ronnie Sahlberg <lsahlber@xxxxxxxxxx> > > Possibly change the output from > pid=6633 tid=0x0 sid=0x0 cmd=0 mid=0 > to > cmd=0 mid=0 pid=6633 tid=0x0 sid=0x0 > > just to make it easier for human-searching. I think the cmd will be useful much more often than pid/tid/sid > and this would make it easier to look for as all cmd= entries will be aligned to the same column. My instinct is to preserve the consistency by beginning with the the fields that will be in 90% of the commands: tree id and session id (tid and sid), which would cause pid to move after sid or after cmd, but I would prefer to wait on reordering fields and fixing alignment till we add another set of tracepoints (e.g. in FreeXid, and in SMB2_open and in the caller of negprot/sessionsetup) - we should then have a better idea what formatting would make it slightly more consistent and readable.
