It seems the first error assignment in if branch is redundant. Signed-off-by: Chengguang Xu <cgxu519@xxxxxxx> --- fs/xattr.c | 1 - 1 file changed, 1 deletion(-) diff --git a/fs/xattr.c b/fs/xattr.c index 61cd28b..8686050 100644 --- a/fs/xattr.c +++ b/fs/xattr.c @@ -354,7 +354,6 @@ int __vfs_setxattr_noperm(struct dentry *dentry, const char *name, if (error) return error; if (inode->i_op->listxattr && (inode->i_opflags & IOP_XATTR)) { - error = -EOPNOTSUPP; error = inode->i_op->listxattr(dentry, list, size); } else { error = security_inode_listsecurity(inode, list, size); -- 1.8.3.1