On Mon, May 14, 2018 at 10:31 PM, Waiman Long <longman@xxxxxxxxxx> wrote: > There are use cases where a rwsem can be acquired by one task, but > released by another task. In thess cases, it may not be appropriate > for the lock waiters to spin on the task that acquires the lock. > One example will be the filesystem freeze/thaw code. > > To handle such use cases, a new RWSEM_WRITER_OWNED_NOSPIN > flag can now be set in the owner field of the rwsem by the new > rwsem_set_writer_owned_nospin() function to indicate that the rwsem is > writer owned, but optimistic spinning on the rwsem should be disabled. > > Later on, the new rwsem_set_writer_owned() function can be called to > set the new owner, if it is known. This function should not be called > without a prior rwsem_set_writer_owned_nospin() call. > > Signed-off-by: Waiman Long <longman@xxxxxxxxxx> Makes sense to me. one nit. > > +static inline void __rwsem_set_writer_owned(struct rw_semaphore *sem, > + struct task_struct *task) rwsem_set_owner() doesn't pass in task argument and IMO __rwsem_set_writer_owned() shouldn't either. Thanks, Amir.
