On Mon, May 14, 2018 at 06:00:41PM +0100, Al Viro wrote: > On Mon, May 14, 2018 at 12:27:04PM -0400, J. Bruce Fields wrote: > > > > if (!err) > > > > err = fh_update(reshp); > > > > > > > > at the end of nfsd_create_locked. > > > > > > Might be too late for that, though - the trouble hits when we hit > > > nfsd_create_setattr(). > > > > Oh, got it. Could move the bottom fh_update to just above the > > nfsd_create_setattr(), though? > > Probably, but I'm not comfortable enough with the nfsd guts wrt in-core > fhandle and assumptions made by users of such, so I'd rather bounce that > question to nfsd maintainers ;-) I'm fine with doing it as in your patch and then queuing up cleanup later. --b.
