On Sun, May 13, 2018 at 10:30:16PM +0100, Al Viro wrote: > From: Al Viro <viro@xxxxxxxxxxxxxxxxxx> > > have all post-xfs_lookup() branches converge on d_splice_alias() I think this would be even better if you'd switch xfs_lookup so that it returns a struct inode instead or ERR_PTR instead of an int and a struct xfs_inode in the argument first. That is what all callers want anyway.