On Sun, 13 May 2018, Al Viro wrote: > > simpler code that way, actually > > Signed-off-by: Al Viro <viro@xxxxxxxxxxxxxxxxxx> Agreed. Acked-by: Nicolas Pitre <nico@xxxxxxxxxx> Please feel free to carry this patch in your repo as you see fit. Mine is empty wrt cramfs at the moment and generating a pull req to Linus to bounce only one patch from you would be silly. > --- > fs/cramfs/inode.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/fs/cramfs/inode.c b/fs/cramfs/inode.c > index 017b0ab19bc4..4756e9daa0b2 100644 > --- a/fs/cramfs/inode.c > +++ b/fs/cramfs/inode.c > @@ -808,10 +808,7 @@ static struct dentry *cramfs_lookup(struct inode *dir, struct dentry *dentry, un > } > out: > mutex_unlock(&read_mutex); > - if (IS_ERR(inode)) > - return ERR_CAST(inode); > - d_add(dentry, inode); > - return NULL; > + return d_splice_alias(inode, dentry); > } > > static int cramfs_readpage(struct file *file, struct page *page) > -- > 2.11.0 > > >
