Re: [RFC][PATCH] fix breakage caused by d_find_alias() semantics change

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, May 13, 2018 at 12:48 PM Al Viro <viro@xxxxxxxxxxxxxxxxxx> wrote:
> >
> > Can we just add a big comment to that effect?

> Point taken.  How about the following variant?

Thanks, LGTM.

I get the feeling that this is something where we could do something clever
("put hashed/directory aliases at the beginning of the list, push unhashed
ones at the end"), and avoid the whole loop in d_find_alias() (and then
"d_find_any_alias()" would also automatically prefer a hashed one without
even calling d_find_alias first). But I doubt it matters. And the alias
list is a hlist, so maybe it would be too painful to try to be clever
anyway.

                  Linus



[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]

  Powered by Linux