On Thu, May 10, 2018 at 03:49:53PM -0600, Andreas Dilger wrote: > Would it make sense to change the bio_add_page() and bio_add_pc_page() > to use the more common convention instead of continuing the spread of > this non-standard calling convention? This is doubly problematic since > "off" and "len" are both unsigned int values so it is easy to get them > mixed up, and just reordering the bio_add_page() arguments would not > generate any errors. We have more than hundred callers. I don't think we want to create so much churn just to clean things up a bit without any meaѕurable benefit. And even if you want to clean it up I'd rather keep it away from my iomap/xfs buffered I/O series :) > One option would be to rename this function bio_page_add() so there are > build errors or first add bio_page_add() and mark bio_add_page() > deprecated and allow some short time for transition? There are about > 50 uses under drivers/ and 50 uses under fs/. If you think the churn is worthwhile send a separate series for that. My two new functions should have very few callers even by then, so feel free to just update them as well.
