On Mon, May 07, 2018 at 04:30:02PM -0700, Luis R. Rodriguez wrote: > This makes it clearer this code is part of the coredump code, and > is not an exported generic helper from kernel/umh.c. > > Signed-off-by: Luis R. Rodriguez <mcgrof@xxxxxxxxxx> > --- > fs/coredump.c | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/fs/coredump.c b/fs/coredump.c > index 1e2c87acac9b..566504781683 100644 > --- a/fs/coredump.c > +++ b/fs/coredump.c > @@ -508,7 +508,7 @@ static void wait_for_dump_helpers(struct file *file) > } > > /* > - * umh_pipe_setup > + * coredump_pipe_setup > * helper function to customize the process used > * to collect the core in userspace. Specifically > * it sets up a pipe and installs it as fd 0 (stdin) > @@ -518,7 +518,7 @@ static void wait_for_dump_helpers(struct file *file) > * is a special value that we use to trap recursive > * core dumps > */ > -static int umh_pipe_setup(struct subprocess_info *info, struct cred *new) > +static int coredump_pipe_setup(struct subprocess_info *info, struct cred *new) I think this renaming makes sense. How do we want to proceed? I can take it as part of my series and get the whole thing through net-next or folks want to apply this separately?
