On Tue, May 08, 2018 at 11:59:45PM +0200, Florian Weimer wrote: > On 05/08/2018 11:24 PM, Goldwyn Rodrigues wrote: > >copy_file_range calls do_splice_direct() if fs->clone_file_range > >or fs->copy_file_range() is not available. However, do_splice_direct() > >converts holes to zeros. Detect holes in the file_in range, and > >create them in the corresponding file_out range. > > Should this be restricted to calls to copy_file_range with a > (yet-to-be-defined) flag? > > I was under the impression that the hole-filling nature of > copy_file_range was not a bug. It's not a bug, but it's currently undefined behaviour. i.e. some filesystem implementations will hole fill while others won't, and you cannot predict ahead of time what will happen. Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx
