>> Although vm_insert_mixed_mkwrite () is getting called only from dax, >> but if we directly change it to vmf_insert_mixed_mkwrite() >> with return type vm_fault_t, we end with changing multiple functions >> recursively. In my opinion, it will complicate things. >> >> It's better to go with current inline vmf_insert_mixed_mkwrite() approach. > > No, it's not. The point is to create patches which are self-contained > and don't break anything. So we can't change vm_insert_mixed because > it has so many users, and we need to transition to it gradually. > But vm_insert_mixed_mkwrite only has one user, and we can just change > both at the same time. Agree with you. I have send both the patches cc'ing mm and fsdevel list. vmf_insert_mixed_mkwrite patch has to go first in linus tree.
