On Tue, Apr 17, 2018 at 7:38 PM, Jan Kara <jack@xxxxxxx> wrote: > On Thu 05-04-18 16:18:08, Amir Goldstein wrote: >> Introduce helpers fsnotify_iter_first() and fsnotify_iter_next() >> to abstract the inode / vfsmount marks merged list iteration. >> >> This is a preparation patch before generalizing mark list >> iteration to more mark object types (i.e. super block marks). >> >> Signed-off-by: Amir Goldstein <amir73il@xxxxxxxxx> > > And another naming suggestion :) > Yeh, too many dimensions in this iteration makes naming a challange... > >> /* >> + * iter_info is a multi head priority queue of marks. >> + * fsnotify_iter_first() picks a subset of marks from queue heads, all with the >> + * same priority and clears the type_mask for other marks. >> + * Returns the type_mask of the chosen subset. >> + */ >> +static unsigned int fsnotify_iter_first(struct fsnotify_iter_info *iter_info) > > fsnotify_iter_select_report_types()? > Fine. Thanks, Amir.
