Re: [PATCH 05/20] afs: Implement @sys substitution handling

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Al Viro <viro@xxxxxxxxxxxxxxxxxx>
Subject: Re: [PATCH 05/20] afs: Implement @sys substitution handling
From: David Howells <dhowells@xxxxxxxxxx>
Date: Fri, 06 Apr 2018 09:13:03 +0100
Cc: dhowells@xxxxxxxxxx, torvalds@xxxxxxxxxxxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, linux-afs@xxxxxxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
In-reply-to: <20180406065118.GZ30522@ZenIV.linux.org.uk>
Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903

Al Viro <viro@xxxxxxxxxxxxxxxxxx> wrote:

> lookup_one_len() seriously depends upon exclusive lock

In the code it says:

	WARN_ON_ONCE(!inode_is_locked(base->d_inode));

which checks i_rwsem, but in the banner comment it says:

	* The caller must hold base->i_mutex.

is one of these wrong?

David

Follow-Ups:
- Re: [PATCH 05/20] afs: Implement @sys substitution handling
  - From: Nikolay Borisov

References:
- Re: [PATCH 05/20] afs: Implement @sys substitution handling
  - From: Al Viro
- [PATCH 00/20] afs: Fixes and development
  - From: David Howells
- [PATCH 05/20] afs: Implement @sys substitution handling
  - From: David Howells

Prev by Date: Re: WARNING in kill_block_super
Next by Date: mmotm git tree since-4.16 branch created (was: mmotm 2018-04-05-16-59 uploaded)
Previous by thread: Re: [PATCH 05/20] afs: Implement @sys substitution handling
Next by thread: Re: [PATCH 05/20] afs: Implement @sys substitution handling
Index(es):
- Date
- Thread

[Index of Archives] [Linux Ext4 Filesystem] [Union Filesystem] [Filesystem Testing] [Ceph Users] [Ecryptfs] [AutoFS] [Kernel Newbies] [Share Photos] [Security] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux Cachefs] [Reiser Filesystem] [Linux RAID] [Samba] [Device Mapper] [CEPH Development]