Re: [PATCH 4/9] aio: sanitize ki_list handling

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Christoph Hellwig <hch@xxxxxx>
Subject: Re: [PATCH 4/9] aio: sanitize ki_list handling
From: Al Viro <viro@xxxxxxxxxxxxxxxxxx>
Date: Thu, 22 Mar 2018 15:24:14 +0000
Cc: Avi Kivity <avi@xxxxxxxxxxxx>, linux-aio@xxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, linux-api@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
In-reply-to: <20180321073232.13366-5-hch@lst.de>
User-agent: Mutt/1.9.1 (2017-09-22)

On Wed, Mar 21, 2018 at 08:32:27AM +0100, Christoph Hellwig wrote:

> -	if (iocb->ki_list.next) {
> +	if (!list_empty_careful(iocb->ki_list.next)) {

Umm...  Why not list_empty_careful(&iocb->ki_list)?

Follow-Ups:
- Re: [PATCH 4/9] aio: sanitize ki_list handling
  - From: Christoph Hellwig

References:
- io_pgetevents & aio fsync
  - From: Christoph Hellwig
- [PATCH 4/9] aio: sanitize ki_list handling
  - From: Christoph Hellwig

Prev by Date: Re: [RFC v2 83/83] Sysfs support.
Next by Date: Re: [PATCH v7 13/14] xfs: prepare xfs_break_layouts() for another layout type
Previous by thread: Re: [PATCH 4/9] aio: sanitize ki_list handling
Next by thread: Re: [PATCH 4/9] aio: sanitize ki_list handling
Index(es):
- Date
- Thread

[Index of Archives] [Linux Ext4 Filesystem] [Union Filesystem] [Filesystem Testing] [Ceph Users] [Ecryptfs] [AutoFS] [Kernel Newbies] [Share Photos] [Security] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux Cachefs] [Reiser Filesystem] [Linux RAID] [Samba] [Device Mapper] [CEPH Development]

Powered by Linux