On Wed, Feb 06, 2008 at 07:43:01AM -0600, Steve French wrote: > I only remember missing a loop unwinding on exit style comment of > yours that was not addressed in what got integrated. I will go back > through your notes again to see if I missed one. - there's still all that CONFIG_CIFS_DFS_UPCALL ifdefery left in cifsfs.c that should go into a helper - cifs_fs_type is made non-static but not actually used anywhere - dfs_info3_param still has the camelCase PathConsumed member name - dfs_shrink_umount_helper is called under ifdef instead of a proper stub - dns_resolve.[ch] still have the filename mentioned in the top of file comments - dns_resolve.c still has non-kerneldoc function description comments - dns_resolve.h still has the useless __KERNEL__ ifdef - the unused free_dfs_info_param function is still around - lots of useless and confusing braces left - dns_resolve_server_name_to_ip still has deeply nested conditionals instead of proper goto unwinding There's a reason why we usually repost patches to the list after addressing review comments.. and while I'm at it a lot of the non-DFS additions to cifs aren't quite up to standards for kernel code either, lots of useless braces, wierd coding style and ifdef mania. What happened to the idea of running all cifs patches past linux-fsdevel? Also running checkpath.pl over them might be a not too bad idea. - To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
