Revert "dm btree: use GFP_NOFS in dm_btree_del()"

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Mike, Joe,

Please consider reverting commit 9f9ef0657d53d988dc07b096052b3dd07d6e3c46.
The reasoning is flawed -- just because something is an ioctl does not
mean that you should be using GFP_NOFS.  The only reason to use GFP_NOFS
is if the filesystem is holding a lock which means that calling into
the filesystem to free memory would deadlock.

If you have a lockdep splat or some chain of reasoning that shows
that there is a filesystem with, eg, an open transaction or holding
an fs-wide lock, then please add some more information to the comment.
Because the comment is wrong, I assume the entire commit is incorrect.




[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]

  Powered by Linux