On Wed, Mar 7, 2018 at 6:34 PM, Shakeel Butt <shakeelb@xxxxxxxxxx> wrote: > On Wed, Mar 7, 2018 at 6:23 PM, Randy Dunlap <rdunlap@xxxxxxxxxxxxx> wrote: >> On 03/07/2018 06:20 PM, Randy Dunlap wrote: >>> On 03/07/2018 04:20 PM, akpm@xxxxxxxxxxxxxxxxxxxx wrote: >>>> The mm-of-the-moment snapshot 2018-03-07-16-19 has been uploaded to >>>> >>>> http://www.ozlabs.org/~akpm/mmotm/ >>>> >>>> mmotm-readme.txt says >>>> >>>> README for mm-of-the-moment: >>>> >>>> http://www.ozlabs.org/~akpm/mmotm/ >>>> >>>> This is a snapshot of my -mm patch queue. Uploaded at random hopefully >>>> more than once a week. >>> >>> UML on i386 and/or x86_64: >>> >>> defconfig, CONFIG_MEMCG is not set: >>> >>> ../fs/notify/group.c: In function 'fsnotify_final_destroy_group': >>> ../fs/notify/group.c:41:24: error: dereferencing pointer to incomplete type >>> css_put(&group->memcg->css); >>> ^ >>> >>> From: Shakeel Butt <shakeelb@xxxxxxxxxx> >>> Subject: fs: fsnotify: account fsnotify metadata to kmemcg >> >> >> >> or x86 any time that CONFIG_MEMCG is not enabled. >> >> > > Sorry about that. Replacing this with mem_cgroup_put(group->memcg) > should solve the issue on the mm tree. Andrew, do you want me to extract mem_cgroup_put() API from Roman's patches as a separate patch?