Hi Al, While this patch was generated by a machine (CodeAI), we manually reviewed and submitted it to this mailing list. I do apologize for the marketing speech. We'll try to tone that down. You are correct in saying this isn't really a security defect. It's more of a code quality issue. Perhaps we should be more specific in our defect classification by stating that CodeAI finds and fixes CWEs (common weakness enumeration defects). This issue corresponds to CWE 563 "Assignment to Variable without Use". -Ben On Thu, Feb 22, 2018 at 12:40 PM, Al Viro <viro@xxxxxxxxxxxxxxxxxx> wrote: > On Thu, Feb 22, 2018 at 12:11:53PM -0500, C0deAi wrote: >> Hi my name is Benjamin Bales. >> >> I am the founder and creator of CodeAI, >> the first non-human contributor to your software project. > > Assuming that your average checkpatch.pl wanker doesn't qualify, you mean? > >> CodeAI finds >> and fixes security defects for you. It fixed 327. It wants to merge a >> fix for a useless assignment. > > Which is not a security defect by any stretch of imagination. Incidentally, > any compiler is going to be capable of detecting and removing that... > > It's -><- this close to spamming links to one's project/community/social > shmedia webshite/whatnot. Complete with "if you want to see how good it is, > sign up for free account", even... > > You might want to tone that down. If it's really a bot posting (and not > a human-curated output of a script[1]), it's very close to the "banned > as a spambot" territory. > > [1] in which case there would be arseloads of prior art, going back to at > least 2004 or so - and that's the ones I know about. -- Sincerely, CodeAI Tech Support Team
