On Sun, Jan 21, 2018 at 6:04 PM, Deepa Dinamani <deepa.kernel@xxxxxxxxx> wrote: > + t.tv_nsec -= t.tv_nsec % gran; This doesn't actuall ywork if tv_nsec is negative. Which may not be an issue in most cases, but did somebody check utimensat() or whatever? > + WARN(1, "illegal file time granularity: %u", gran); .. small nit: we generally should use 'invalid' rather than 'illegal'. No cops will hunt you down for things like this. Linus