Hi Rakesh, Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v4.15-rc7 next-20180112] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Rakesh-Pandit/vfs-remove-unused-argument-in-iterate_bdevs/20180114-215207 config: i386-randconfig-x071-201802 (attached as .config) compiler: gcc-7 (Debian 7.2.0-12) 7.2.1 20171025 reproduce: # save the attached .config to linux build tree make ARCH=i386 All errors (new ones prefixed by >>): fs/sync.c: In function 'sys_sync': >> fs/sync.c:116:16: error: passing argument 1 of 'iterate_bdevs' from incompatible pointer type [-Werror=incompatible-pointer-types] iterate_bdevs(fdatawrite_one_bdev); ^~~~~~~~~~~~~~~~~~~ In file included from fs/sync.c:8:0: include/linux/fs.h:2475:20: note: expected 'void (*)(struct block_device *, void *)' but argument is of type 'void (*)(struct block_device *)' static inline void iterate_bdevs(void (*f)(struct block_device *, void *)) ^~~~~~~~~~~~~ fs/sync.c:117:16: error: passing argument 1 of 'iterate_bdevs' from incompatible pointer type [-Werror=incompatible-pointer-types] iterate_bdevs(fdatawait_one_bdev); ^~~~~~~~~~~~~~~~~~ In file included from fs/sync.c:8:0: include/linux/fs.h:2475:20: note: expected 'void (*)(struct block_device *, void *)' but argument is of type 'void (*)(struct block_device *)' static inline void iterate_bdevs(void (*f)(struct block_device *, void *)) ^~~~~~~~~~~~~ fs/sync.c: In function 'do_sync_work': fs/sync.c:133:16: error: passing argument 1 of 'iterate_bdevs' from incompatible pointer type [-Werror=incompatible-pointer-types] iterate_bdevs(fdatawrite_one_bdev); ^~~~~~~~~~~~~~~~~~~ In file included from fs/sync.c:8:0: include/linux/fs.h:2475:20: note: expected 'void (*)(struct block_device *, void *)' but argument is of type 'void (*)(struct block_device *)' static inline void iterate_bdevs(void (*f)(struct block_device *, void *)) ^~~~~~~~~~~~~ fs/sync.c:136:16: error: passing argument 1 of 'iterate_bdevs' from incompatible pointer type [-Werror=incompatible-pointer-types] iterate_bdevs(fdatawrite_one_bdev); ^~~~~~~~~~~~~~~~~~~ In file included from fs/sync.c:8:0: include/linux/fs.h:2475:20: note: expected 'void (*)(struct block_device *, void *)' but argument is of type 'void (*)(struct block_device *)' static inline void iterate_bdevs(void (*f)(struct block_device *, void *)) ^~~~~~~~~~~~~ cc1: some warnings being treated as errors vim +/iterate_bdevs +116 fs/sync.c 97 98 /* 99 * Sync everything. We start by waking flusher threads so that most of 100 * writeback runs on all devices in parallel. Then we sync all inodes reliably 101 * which effectively also waits for all flusher threads to finish doing 102 * writeback. At this point all data is on disk so metadata should be stable 103 * and we tell filesystems to sync their metadata via ->sync_fs() calls. 104 * Finally, we writeout all block devices because some filesystems (e.g. ext2) 105 * just write metadata (such as inodes or bitmaps) to block device page cache 106 * and do not sync it on their own in ->sync_fs(). 107 */ 108 SYSCALL_DEFINE0(sync) 109 { 110 int nowait = 0, wait = 1; 111 112 wakeup_flusher_threads(WB_REASON_SYNC); 113 iterate_supers(sync_inodes_one_sb, NULL); 114 iterate_supers(sync_fs_one_sb, &nowait); 115 iterate_supers(sync_fs_one_sb, &wait); > 116 iterate_bdevs(fdatawrite_one_bdev); 117 iterate_bdevs(fdatawait_one_bdev); 118 if (unlikely(laptop_mode)) 119 laptop_sync_completion(); 120 return 0; 121 } 122 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
Attachment:
.config.gz
Description: application/gzip
