On 01/13/2018 04:48 AM, Matthew Wilcox wrote: > On Sat, Jan 13, 2018 at 10:58:00AM +0530, Chandan Rajendra wrote: >> On Saturday, January 13, 2018 12:37:59 AM IST Randy Dunlap wrote: >>> On 01/12/18 06:11, Chandan Rajendra wrote: >>>> This patchset implements code to support encryption of Ext4 filesystem >>>> instances that have blocksize less than pagesize. The patchset has >>>> been tested on both ppc64 and x86_64 machines. >>> >>> strictly "less than" or "less than or equal to"? >> >> I have tested the patchset for the use cases of "less than or equal to >> page size" i.e. On ppc64, the patchset was tested with blocksizes of >> 4k and 64k. On x86_64, the patchset was tested with blocksizes of 2k >> and 4k. > > I think there's a miscommunication here. ext4 already supports encryption > of filesystems with block size == page size. Chandan is adding support > for encrypting filesystems with block size < page size. Without removing > support for block size == page size ;-) I see. Thanks for the clarification. -- ~Randy