On Fri, Jan 12, 2018 at 07:41:23PM +0530, Chandan Rajendra wrote: > @@ -1642,12 +1642,12 @@ EXPORT_SYMBOL(clean_bdev_aliases); > * constraints in mind (relevant mostly if some > * architecture has a slow bit-scan instruction) > */ > -static inline int block_size_bits(unsigned int blocksize) > +int block_size_bits(unsigned int blocksize) > { > return ilog2(blocksize); > } Could you move this to buffer.h instead please?