On Thu, Jan 11, 2018 at 04:06:45PM +0100, Jan Kara wrote: > On Thu 11-01-18 16:04:07, Rakesh Pandit wrote: > > @@ -2472,7 +2472,7 @@ static inline int thaw_bdev(struct block_device *bdev, struct super_block *sb) > > return 0; > > } > > > > -static inline void iterate_bdevs(void (*f)(struct block_device *, void *), void *arg) > > +static inline void iterate_bdevs(void (*f)(struct block_device *, void *)) > > You've missed the void * in (*f) prototype here. Other than that: > > Reviewed-by: Jan Kara <jack@xxxxxxx> Thanks for catching it. I would repost with your tag and fix it same time.