On Friday 25 January 2008, Jan Kara wrote: > > If ext3's DIO code only touches transactions in get_block, then it can > > violate data=ordered rules. Basically the transaction that allocates > > the blocks might commit before the DIO code gets around to writing them. > > > > A crash in the wrong place will expose stale data on disk. > > Hmm, I've looked at it and I don't think so - look at the rationale in > the patch below... That patch should fix the lock-inversion problem (at > least I see no lockdep warnings on my test machine). > Ah ok, when I was looking at this I was allowing holes to get filled without falling back to buffered. But, with the orphan inode entry protecting things I see how you're safe with this patch. -chris - To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html