Miklos Szeredi wrote:
Also add minor fix: when parsing the "mode" option, mask with S_IALLUGO instead of ~S_IFMT, which could leave unsed bits in the mask.
umode_t is 16 bits, so it doesn't. The change is still good, of course.
+ if (config.mode != DEVPTS_DEFAULT_MODE) + seq_printf(seq, ",mode=%03o", config.mode);
I would rather this be unconditional, than that it be conditional on something other than the user having specified it in the first place.
Other than that, Acked-by: H. Peter Anvin <hpa@xxxxxxxxx> -hpa - To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
