Re: [PATCH 1/2] epoll: use the waitqueue lock to protect ep->wq

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Ingo Molnar <mingo@xxxxxxxxxx>
Subject: Re: [PATCH 1/2] epoll: use the waitqueue lock to protect ep->wq
From: Christoph Hellwig <hch@xxxxxx>
Date: Thu, 14 Dec 2017 14:06:51 +0100
Cc: Christoph Hellwig <hch@xxxxxx>, Peter Zijlstra <a.p.zijlstra@xxxxxxxxx>, Ingo Molnar <mingo@xxxxxxxxxx>, Peter Zijlstra <peterz@xxxxxxxxxxxxx>, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, Al Viro <viro@xxxxxxxxxxxxxxxxxx>, Jason Baron <jbaron@xxxxxxxxxx>, linux-fsdevel@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
In-reply-to: <20171207004914.lxu2dz6cmxgnrou3@gmail.com>
User-agent: Mutt/1.5.17 (2007-11-01)

> Hm, that reads a bit weirdly. How about:
> 
>  The epoll code currently uses the unlocked waitqueue helpers for managing
>  ep->wq, but instead of holding the waitqueue lock around these calls, it
>  uses its own ep->lock spinlock.

Thanks, fixed.

References:
- waitqueue lockdep annotation
  - From: Christoph Hellwig
- [PATCH 1/2] epoll: use the waitqueue lock to protect ep->wq
  - From: Christoph Hellwig
- Re: [PATCH 1/2] epoll: use the waitqueue lock to protect ep->wq
  - From: Ingo Molnar

Prev by Date: Re: [PATCH 1/2] epoll: use the waitqueue lock to protect ep->wq
Next by Date: Re: [PATCH 2/2] sched/wait: assert the wait_queue_head lock is held in __wake_up_common
Previous by thread: Re: [PATCH 1/2] epoll: use the waitqueue lock to protect ep->wq
Next by thread: Re: [PATCH 1/2] epoll: use the waitqueue lock to protect ep->wq
Index(es):
- Date
- Thread

[Index of Archives] [Linux Ext4 Filesystem] [Union Filesystem] [Filesystem Testing] [Ceph Users] [Ecryptfs] [AutoFS] [Kernel Newbies] [Share Photos] [Security] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux Cachefs] [Reiser Filesystem] [Linux RAID] [Samba] [Device Mapper] [CEPH Development]

Powered by Linux