On Wed, Dec 13, 2017 at 11:27:00AM -0500, Jeff Moyer wrote: > Matthew Wilcox <willy@xxxxxxxxxxxxx> writes: > > > On Wed, Dec 13, 2017 at 09:42:52PM +0800, Zhen Lei wrote: > >> Below information is reported by a lower kernel version, and I saw the > >> problem still exist in current version. > > > > I think you're right, but what an awful interface we have here! > > The user must not only fetch it, they must validate it separately? > > And if they forget, then userspace is provoking undefined behaviour? Ugh. > > Why not this: > > Why not go a step further and have get_timespec64 check for validity? > I wonder what caller doesn't want that to happen... There are some which don't today. I'm hoping Deepa takes this and goes off and fixes them all up.