On Jan 23 2008 12:18, Bryan Wu wrote: >> [PATCH] procfs: constify function pointer tables >> --- >> arch/alpha/kernel/setup.c | 2 +- >> arch/blackfin/kernel/setup.c | 2 +- >> [...] >> diff --git a/arch/alpha/kernel/setup.c b/arch/alpha/kernel/setup.c >> index bd5e68c..823f18e 100644 >> --- a/arch/alpha/kernel/setup.c >> +++ b/arch/alpha/kernel/setup.c >> @@ -1472,7 +1472,7 @@ c_stop(struct seq_file *f, void *v) >> { >> } >> >> -struct seq_operations cpuinfo_op = { >> +const struct seq_operations cpuinfo_op = { >> .start = c_start, >> .next = c_next, >> .stop = c_stop, [...] >Thanks, I understand the seq_xxx() API needs "const struct seq_operations *". >So for Blackfin part, I agree with Mike. > >but there are still some other files need add "const": >--- >/opt/git-tree/blackfin-2.6$ grep -r seq_operations arch/* >arch/alpha/kernel/setup.c:struct seq_operations cpuinfo_op = { The patch already touches that :-) - To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html