Huh, you've caught a couple of problems that 0day hasn't sent me yet. Try turning on DAX or TRANSPARENT_HUGEPAGE. Thanks! > -----Original Message----- > From: Dave Chinner [mailto:david@xxxxxxxxxxxxx] > Sent: Tuesday, December 5, 2017 8:51 PM > To: Matthew Wilcox <willy@xxxxxxxxxxxxx> > Cc: Matthew Wilcox <mawilcox@xxxxxxxxxxxxx>; Ross Zwisler > <ross.zwisler@xxxxxxxxxxxxxxx>; Jens Axboe <axboe@xxxxxxxxx>; Rehas > Sachdeva <aquannie@xxxxxxxxx>; linux-mm@xxxxxxxxx; linux- > fsdevel@xxxxxxxxxxxxxxx; linux-f2fs-devel@xxxxxxxxxxxxxxxxxxxxx; linux- > nilfs@xxxxxxxxxxxxxxx; linux-btrfs@xxxxxxxxxxxxxxx; linux-xfs@xxxxxxxxxxxxxxx; > linux-usb@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx > Subject: Re: [PATCH v4 00/73] XArray version 4 > > On Wed, Dec 06, 2017 at 12:45:49PM +1100, Dave Chinner wrote: > > On Tue, Dec 05, 2017 at 04:40:46PM -0800, Matthew Wilcox wrote: > > > From: Matthew Wilcox <mawilcox@xxxxxxxxxxxxx> > > > > > > I looked through some notes and decided this was version 4 of the XArray. > > > Last posted two weeks ago, this version includes a *lot* of changes. > > > I'd like to thank Dave Chinner for his feedback, encouragement and > > > distracting ideas for improvement, which I'll get to once this is merged. > > > > BTW, you need to fix the "To:" line on your patchbombs: > > > > > To: unlisted-recipients: ;, no To-header on input <@gmail- > pop.l.google.com> > > > > This bad email address getting quoted to the cc line makes some MTAs > > very unhappy. > > > > > > > > Highlights: > > > - Over 2000 words of documentation in patch 8! And lots more kernel-doc. > > > - The page cache is now fully converted to the XArray. > > > - Many more tests in the test-suite. > > > > > > This patch set is not for applying. 0day is still reporting problems, > > > and I'd feel bad for eating someone's data. These patches apply on top > > > of a set of prepatory patches which just aren't interesting. If you > > > want to see the patches applied to a tree, I suggest pulling my git tree: > > > > https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgit.infrade > ad.org%2Fusers%2Fwilly%2Flinux- > dax.git%2Fshortlog%2Frefs%2Fheads%2Fxarray-2017-12- > 04&data=02%7C01%7Cmawilcox%40microsoft.com%7Ca3e721545f8b4b9dff1 > 608d53c4bd42f%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C6364 > 81218740341312&sdata=IXNZXXLTf964OQ0eLDpJt2LCv%2BGGWFW%2FQd4Kc > KYu6zo%3D&reserved=0 > > > I also left out the idr_preload removals. They're still in the git tree, > > > but I'm not looking for feedback on them. > > > > I'll give this a quick burn this afternoon and see what catches fire... > > Build warnings/errors: > > ..... > lib/radix-tree.c:700:13: warning: ¿radix_tree_free_nodes¿ defined but not used > [-Wunused-function] > static void radix_tree_free_nodes(struct radix_tree_node *node) > ..... > lib/xarray.c: In function ¿xas_max¿: > lib/xarray.c:291:16: warning: unused variable ¿mask¿ > [-Wunused-variable] > unsigned long mask, max = xas->xa_index; > ^~~~ > ...... > fs/dax.c: In function ¿grab_mapping_entry¿: > fs/dax.c:305:2: error: implicit declaration of function ¿xas_set_order¿; did you > mean ¿xas_set_err¿? [-Werror=implicit-function-declaration] > xas_set_order(&xas, index, size_flag ? PMD_ORDER : 0); > ^~~~~~~~~~~~~ > scripts/Makefile.build:310: recipe for target 'fs/dax.o' failed > make[1]: *** [fs/dax.o] Error 1 > > -Dave. > -- > Dave Chinner > david@xxxxxxxxxxxxx
