Quoting Miklos Szeredi (miklos@xxxxxxxxxx): > > On Mon, 2008-01-21 at 22:25 +0100, Miklos Szeredi wrote: > > > > You have removed the code that checked if the peer or > > > > master mount was in the same namespace before reporting their > > > > corresponding mount-ids. One downside of that approach is the > > > > user will see an mount_id in the output with no corresponding > > > > line to explain the details of the mount_id. > > > > > > Before the change, the peer and master ID's were basically randomly > > > chosen from the peers, which means, it wasn't possible to always > > > determine, that two mounts were peers, or that they were slaves to the > > > same peer group. > > > > > > After the change, this is possible, since the peer ID will be the same > > > for all mounts which are peers. This means, that even though the peer > > > ID might be in a different namespace, it is possible to determine all > > > peers within the same namespace by comparing their peer ID's. > > > > > > I agree with your reasoning on the random id; showing a single > > id avoids clutter. But my point is, why not show a > > id for the master or peer residing in the same namespace? > > Because this way it is possible see propagation between different > namespaces as well, by looking at the mount information for processes > in the different namespaces. Of course, this is only possible with > sufficient privileges. Gotta say I agree with Miklos this would be useful. I'd far prefer to see the id than a -1. thanks, -serge > > Showing a id with no corresponding entry for that id, can be > > intriguing. > > Not if it's clearly documented (will add documentation for the next > submission). > > Miklos > - > To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html - To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
