On Wed, Nov 29, 2017 at 06:04:43PM +0100, Jan Kara wrote: > On Wed 22-11-17 16:15:58, Josef Bacik wrote: > > From: Josef Bacik <jbacik@xxxxxx> > > > > We are converting the writeback counters to use bytes instead of pages, > > so we need to make the batch size for the percpu modifications align > > properly with the new units. Since we used pages before, just multiply > > by PAGE_SIZE to get the equivalent bytes for the batch size. > > > > Signed-off-by: Josef Bacik <jbacik@xxxxxx> > > Looks good to me, just please make this part of patch 5/11. Otherwise > bisection may get broken by too large errors in per-cpu counters of IO > completions... Thanks! > > Honza > > > --- > > lib/flex_proportions.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/lib/flex_proportions.c b/lib/flex_proportions.c > > index 2cc1f94e03a1..b0343ae71f5e 100644 > > --- a/lib/flex_proportions.c > > +++ b/lib/flex_proportions.c > > @@ -166,7 +166,7 @@ void fprop_fraction_single(struct fprop_global *p, > > /* > > * ---- PERCPU ---- > > */ > > -#define PROP_BATCH (8*(1+ilog2(nr_cpu_ids))) > > +#define PROP_BATCH (8*PAGE_SIZE*(1+ilog2(nr_cpu_ids))) So when the patch is going to be updated, please fix the coding style here.
