On Tue, Nov 28, 2017 at 7:30 PM, Josef Bacik <josef@xxxxxxxxxxxxxx> wrote: > From: Josef Bacik <jbacik@xxxxxx> > > Amir noticed that sometimes the xfstests using dm-log-writes would fail > randomly but would work fine after trying again manually. This is > because dm-log-writes writes directly to the device, but the log replay > tools read and write via the block device page cache. Sometimes this > resulted in stale data being in the block device's page cache which > would result in random failures. To handle this simply invalidate the > block device page cache on destruction so any replay of the log device > that follows will be forced to read the new real contents. > > Reported-and-tested-by: Amir Goldstein <amir73il@xxxxxxxxx> I'm fine with the Reported-by, but let's wait a while with this patch so I have more time to torture it. The incidents I got even before the patch did not happen more than a handful of times after running for a few days, so I need some more days to validate the fix. I had already sent you some weird output. Let's see what else comes along. Thanks, Amir.