On Thu 23-11-17 23:21:01, Chao Yu wrote: > @@ -2364,10 +2370,11 @@ static int vfs_load_quota_inode(struct inode *inode, int type, int format_id, > dqopt->flags |= dquot_state_flag(flags, type); > spin_unlock(&dq_state_lock); > > - add_dquot_ref(sb, type); > - > - return 0; > + error = add_dquot_ref(sb, type); > + if (error) > + dquot_disable(sb, type, dqopt->flags); Why dqopt->flags? If anything these flags are shifted by user/group/project shift and combined together for all the types. You need to just pass 'flags' here. Other than that the patch looks good. Honza -- Jan Kara <jack@xxxxxxxx> SUSE Labs, CR
