On Thu, Nov 09, 2017 at 02:09:03PM -0800, Randy Dunlap wrote: > > Searching through lkml, it looks like there have been four attempts to > > fix this issue in the last year or so, but none of them have been > > merged. It would be nice to finally get a fix in. > > > > I agree with the patch, though I would argue that the fix belongs in > > round_pipe_size() so that other callers don't get the same bug. > > Hi Josh, > > Yes, I debated with myself on where to put the patch. I made it more local > instead of global just to have less accidental impact. > > > Andrew has these 4 patches from Joe Lawrence in mmotm: > > pipe-add-proc_dopipe_max_size-to-safely-assign-pipe_max_size.patch > pipe-avoid-round_pipe_size-nr_pages-overflow-on-32-bit.patch > pipe-match-pipe_max_size-data-type-with-procfs.patch > sysctl-check-for-uint_max-before-unsigned-int-min-max.patch > > > Hopefully they can be merged soon. > I blame people who travel a lot. ;) Ah, I missed Joe's patches (and neglected to check linux-next). Thanks! -- Josh
