On 10/30/2017 10:11 AM, Davidlohr Bueso wrote: > On Fri, 27 Oct 2017, Waiman Long wrote: > >> The dlist_for_each_entry_safe() macro in include/linux/dlock-list has >> a use-after-unlock problem where racing condition can happen because >> of a lack of spinlock protection. Fortunately, this macro is not >> currently being used in the kernel. >> >> This patch changes the dlist_for_each_entry_safe() macro so that the >> call to __dlock_list_next_list() is deferred until the next entry is >> being used. That should eliminate the use-after-unlock problem. >> >> Reported-by: Boqun Feng <boqun.feng@xxxxxxxxx> >> Signed-off-by: Waiman Long <longman@xxxxxxxxxx> > > Reviewed-by: Davidlohr Bueso <dbueso@xxxxxxx> > > But would it not be better to merge this patch (among others) into 1/N? > Specifically the newer patches 7-10 should be in the original dlock > implementation instead of adding fixes to incorrect code in the original > commit. Also less of a pita for backporting. > > Thanks, > Davidlohr +191,17 @@ extern void dlock_list_add(struct dlock_list_node > *node, Yes, that is true. I will send out a new version with all the fixes integrated later this week. Cheers, Longman
