On Thu, Oct 26, 2017 at 05:48:04PM +0200, Jan Kara wrote: > But now that I look at XFS implementation again, it misses handling > of VM_FAULT_NEEDSYNC in xfs_filemap_pfn_mkwrite() (ext4 gets this right). > I'll fix this by using __xfs_filemap_fault() for xfs_filemap_pfn_mkwrite() > as well since it mostly duplicates it anyway... Thanks for inquiring! My first patches move xfs_filemap_pfn_mkwrite to use __xfs_filemap_fault, but that didn't work. Wish I'd remember why, though.