On Mon 16-10-17 08:50:30, Viacheslav Dubeyko wrote: > On Mon, 2017-10-16 at 00:42 -0700, Christoph Hellwig wrote: > > On Fri, Oct 13, 2017 at 11:43:19PM -0300, Ernesto A. Fernández wrote: > > > > > > Since there was no more discussion I suppose I should go ahead and > > > do it. I'm using your rationale in the commit message, let me know > > > if > > > either of you wants to be tagged as "Suggested-by", or in any other > > > way. Thank you. > > I don't think I suggested it, but I'd be happy to ACK it: > > > > I believe that it's not right way of doing things. The exclsuion of > this section of code doesn't mean that HFS+ file system driver will not > have any bugs. If we follow this logic then it makes sense to exclude > the whole HFS+ support from the Linux kernel especcially if nobody > cares about HFS+ support anymore. Well, if nobody really uses HFS+ support, it would be best to drop it, yes. However we don't know whether somebody uses it or not and my guess would be that actually someone occasionally uses HFS+ support to read MacOS files. With xattr support the situation is different. It has been broken for four years and nobody complained. That is a good indication nobody uses that code and we can drop it. Furthermore, Christoph pointed out that original HFS+ in MacOS never supported xattrs which makes it even less likely that someone uses that functionality (as you cannot use it if you want your filesystem to stay compatible with MacOS). Honza -- Jan Kara <jack@xxxxxxxx> SUSE Labs, CR
