Re: [PATCH] hfsplus: fix segfault when deleting all attrs of a file

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



--------------------------------------------
On Sun, 8/10/17, Ernesto A. Fernández <ernesto.mnd.fernandez@xxxxxxxxx> wrote:

> I did not give a number because it depends on the size of the xattrs, and I
> imagine the bnode size as well, though I only tested it with the default
> mkfs options. Maybe I should have shared the script I used instead:

> touch test.file
> i=1
> while [ $i -le 250 ]; do
>  setfattr -n user.$i test.file
>  ((++i))
> done
> rm test.file

> Of course, if you set a value to the xattrs you will need fewer.

Yes, including the script in the commit message would be useful; for just the case of default mkfs options is perfectly acceptable. Definitely good to include it in the next revision of your patch. Don't worry about non-default/existing xattrs, or exactly how many is needed; a reliable way (3 times out of 4 say, or repeated running 2-3 times) under default condition is good enough to include.

Hin-Tak



 





[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]
  Powered by Linux