On 09/28/2017 11:29 PM, Andrew Morton wrote: > On Thu, 28 Sep 2017 14:11:41 +0800 Kemi Wang <kemi.wang@xxxxxxxxx> wrote: > >> This is the second step which introduces a tunable interface that allow >> numa stats configurable for optimizing zone_statistics(), as suggested by >> Dave Hansen and Ying Huang. > > Looks OK I guess. > > I fiddled with it a lot. Please consider: > > From: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> > Subject: mm-sysctl-make-numa-stats-configurable-fix > > - tweak documentation > > - move advisory message from start_kernel() into mm_init() (I'm not sure > we really need this message) Actually, I'm not sure we need any of the current messages, or to have them at higher priority than pr_debug()? They are all triggered by admin action, or unconditionally upon boot. OTOH I think that an useful message that's currently missing would be when the static_key_enable() is triggered in auto mode. Bonus points for including the name of the process and the stat file that was read. However static_key_enable() returns void and not whether it actually flipped the switch, so it's not trivial.
