Re: [RFC PATCH 1/3] fs: define new read_iter rwf flag

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Matthew Wilcox <willy@xxxxxxxxxxxxx>
Subject: Re: [RFC PATCH 1/3] fs: define new read_iter rwf flag
From: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
Date: Thu, 28 Sep 2017 08:51:30 -0700
Cc: Mimi Zohar <zohar@xxxxxxxxxxxxxxxxxx>, LSM List <linux-security-module@xxxxxxxxxxxxxxx>, linux-fsdevel <linux-fsdevel@xxxxxxxxxxxxxxx>, linux-integrity@xxxxxxxxxxxxxxx, Christoph Hellwig <hch@xxxxxxxxxxxxx>, Linux Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx>, Jan Kara <jack@xxxxxxx>, "Theodore Ts'o" <tytso@xxxxxxx>
In-reply-to: <20170928135416.GA30859@bombadil.infradead.org>

On Thu, Sep 28, 2017 at 6:54 AM, Matthew Wilcox <willy@xxxxxxxxxxxxx> wrote:
>
> I don't like adding a bool parameter everywhere.  Why not add a flag
> to the kiocb ki_flags?
>
> #define IOCB_RWSEM_HELD         (1 << 8)

Yeah, I think that would be a nicer approach, with filesystems that
don't care being able to just ignore it entirely.

                     Linus

References:
- [RFC PATCH 0/3] define new read_iter file operation rwf flag
  - From: Mimi Zohar
- [RFC PATCH 1/3] fs: define new read_iter rwf flag
  - From: Mimi Zohar
- Re: [RFC PATCH 1/3] fs: define new read_iter rwf flag
  - From: Matthew Wilcox

Prev by Date: Re: [PATCH 03/12] buffer: eliminate the need to call free_more_memory() in __getblk_slow()
Next by Date: Re: [RFC PATCH manpages] write.2, fsync.2, close.2: update description of error codes
Previous by thread: Re: [RFC PATCH 1/3] fs: define new read_iter rwf flag
Next by thread: [RFC PATCH 3/3] fs: detect that the i_rwsem has already been taken exclusively
Index(es):
- Date
- Thread

[Index of Archives] [Linux Ext4 Filesystem] [Union Filesystem] [Filesystem Testing] [Ceph Users] [Ecryptfs] [AutoFS] [Kernel Newbies] [Share Photos] [Security] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux Cachefs] [Reiser Filesystem] [Linux RAID] [Samba] [Device Mapper] [CEPH Development]