On Thu, Jan 10 2008, Christoph Hellwig wrote: > On Thu, Jan 10, 2008 at 09:44:57AM +0100, Jens Axboe wrote: > > > IMHO this shouldn't be done in the loop driver anyway. Filesystems have > > > their own effricient extent lookup trees (well, at least xfs and btrfs > > > do), and we should leverage that instead of reinventing it. > > > > Completely agree, it's just needed right now for this solution since all > > we have is a crappy bmap() interface to get at those mappings. > > So let's fix the interface instead of piling crap ontop of it. As I > said I think Peter has something to start with so let's beat on it > until we have something suitable. Sure, I'm all for doing it the Right Way. I wasn't aware of anything Peter was doing in this area, so lets please see it. It's not like opportunities to improve this haven't been around. My plan was/is to convert to using the get_block() tricks of O_DIRECT, one could easily argue that the work should have been done then. And perhaps direct-io.c wouldn't be such a steaming pile of crap if it had been done, and loop would already be fine since we could have tapped into that. > If we aren't done by end of Feb I'm happy to host a hackfest to get it > sorted around the fs/storage summit.. Count me in :) -- Jens Axboe - To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
