Re: [PATCH V2 1/1] audit: Record fanotify access control decisions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Steve,

[auto build test ERROR on linus/master]
[also build test ERROR on v4.14-rc2 next-20170926]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Steve-Grubb/audit-Record-fanotify-access-control-decisions/20170927-023432
config: x86_64-randconfig-x013-201739 (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All errors (new ones prefixed by >>):

   fs/notify//fanotify/fanotify.c: In function 'fanotify_get_response':
>> fs/notify//fanotify/fanotify.c:93:3: error: implicit declaration of function 'audit_fanotify' [-Werror=implicit-function-declaration]
      audit_fanotify(event->response & ~FAN_AUDIT);
      ^~~~~~~~~~~~~~
   cc1: some warnings being treated as errors

vim +/audit_fanotify +93 fs/notify//fanotify/fanotify.c

    58	
    59	#ifdef CONFIG_FANOTIFY_ACCESS_PERMISSIONS
    60	static int fanotify_get_response(struct fsnotify_group *group,
    61					 struct fanotify_perm_event_info *event,
    62					 struct fsnotify_iter_info *iter_info)
    63	{
    64		int ret;
    65	
    66		pr_debug("%s: group=%p event=%p\n", __func__, group, event);
    67	
    68		/*
    69		 * fsnotify_prepare_user_wait() fails if we race with mark deletion.
    70		 * Just let the operation pass in that case.
    71		 */
    72		if (!fsnotify_prepare_user_wait(iter_info)) {
    73			event->response = FAN_ALLOW;
    74			goto out;
    75		}
    76	
    77		wait_event(group->fanotify_data.access_waitq, event->response);
    78	
    79		fsnotify_finish_user_wait(iter_info);
    80	out:
    81		/* userspace responded, convert to something usable */
    82		switch (event->response & ~FAN_AUDIT) {
    83		case FAN_ALLOW:
    84			ret = 0;
    85			break;
    86		case FAN_DENY:
    87		default:
    88			ret = -EPERM;
    89		}
    90	
    91		/* Check if the response should be audited */
    92		if (event->response & FAN_AUDIT)
  > 93			audit_fanotify(event->response & ~FAN_AUDIT);
    94	
    95		event->response = 0;
    96	
    97		pr_debug("%s: group=%p event=%p about to return ret=%d\n", __func__,
    98			 group, event, ret);
    99		
   100		return ret;
   101	}
   102	#endif
   103	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip


[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]
  Powered by Linux